[AIDynamo] comparison report - #977
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughChangesAI Dynamo now supports a registered comparison report that parses benchmark and accuracy CSV outputs, normalizes LLM-serving metrics, generates HTML, and is covered by registry and end-to-end tests. AI Dynamo comparison reporting
Estimated code review effort: 3 (Moderate) | ~25 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/cloudai/workloads/ai_dynamo/report_generation_strategy.py`:
- Around line 146-150: Update the four percentile assignments in the report
generation strategy to use an explicit None check rather than truthiness when
falling back to unavailable. Apply this to median_ttft_ms, p99_ttft_ms,
median_tpot_ms, and p99_tpot_ms so valid zero values are preserved.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 5edb70cd-0825-4e9f-9af3-ed3a1109b6df
📒 Files selected for processing (8)
doc/workloads/ai_dynamo.rstsrc/cloudai/registration.pysrc/cloudai/workloads/ai_dynamo/__init__.pysrc/cloudai/workloads/ai_dynamo/comparison_report.pysrc/cloudai/workloads/ai_dynamo/report_generation_strategy.pysrc/cloudai/workloads/common/llm_serving_report.pytests/test_init.pytests/workloads/ai_dynamo/test_comparison_report.py
Summary
Add comparison report for AI Dynamo
Test Plan
Additional Notes