Skip to content

Correct issues when INSTALL_CUCO is set to OFF#226

Merged
PointKernel merged 2 commits into
NVIDIA:devfrom
robertmaynard:improve_install_rules
Sep 1, 2022
Merged

Correct issues when INSTALL_CUCO is set to OFF#226
PointKernel merged 2 commits into
NVIDIA:devfrom
robertmaynard:improve_install_rules

Conversation

@robertmaynard

@robertmaynard robertmaynard commented Aug 30, 2022

Copy link
Copy Markdown
Collaborator

While #216 allows cuco to have install rules disabled it missed a couple of bits which are corrected with this PR:

  • nvbench and google bench still installed files
  • when INSTALL_CUCO is OFF we still need to generate a cuco-config in the build directory

@robertmaynard robertmaynard added type: bug Something isn't working topic: build CMake build issue Needs Review Awaiting reviews before merging labels Aug 30, 2022
@vyasr

vyasr commented Aug 31, 2022

Copy link
Copy Markdown
Collaborator

@PointKernel do you know what the failing test here is about? Naively it looks like a GH check to make sure that the PR is listed on a GH project, but this repo doesn't have any projects AFAICT so I'm not sure that's what it's asking for.

@PointKernel

PointKernel commented Sep 1, 2022

Copy link
Copy Markdown
Member

Naively it looks like a GH check to make sure that the PR is listed on a GH project, but this repo doesn't have any projects AFAICT so I'm not sure that's what it's asking for.

We can still merge the PR while the project-check is failed. @jrhemstad may know the right way to handle this.

@jrhemstad

jrhemstad commented Sep 1, 2022

Copy link
Copy Markdown
Collaborator

Yeah, you can ignore that. It's been fixed and I don't know how to retrigger that check.

@PointKernel

PointKernel commented Sep 1, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

rerun tests

Not working as expected.

@robertmaynard

robertmaynard commented Sep 1, 2022

Copy link
Copy Markdown
Collaborator Author

Should I re-open as a new PR?

@PointKernel PointKernel merged commit 77593b3 into NVIDIA:dev Sep 1, 2022
@PointKernel

PointKernel commented Sep 1, 2022

Copy link
Copy Markdown
Member

Should I re-open as a new PR?

No need to make things complicated. I just merged it as it is.

@bdice bdice mentioned this pull request Sep 6, 2022
Merged
@robertmaynard robertmaynard deleted the improve_install_rules branch September 6, 2022 15:57
rapids-bot Bot pushed a commit to rapidsai/rapids-cmake that referenced this pull request Sep 6, 2022
@bdice
Update cuCollections to fix issue with INSTALL_CUCO set to OFF. (#261)
ee08ba8 
This updates the cuCollections version to include a fix for when `INSTALL_CUCO` is set to `OFF`: NVIDIA/cuCollections#226

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Robert Maynard (https://github.com/robertmaynard)

URL: #261
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PointKernel PointKernel PointKernel approved these changes

Assignees

No one assigned

Labels

Needs Review Awaiting reviews before merging topic: build CMake build issue type: bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@robertmaynard @vyasr @PointKernel @jrhemstad