Skip to content

Add WSL runners to CI test matrix#1880

Merged
leofang merged 4 commits intomainfrom
ci/add-wsl-runners
Apr 8, 2026
Merged

Add WSL runners to CI test matrix#1880
leofang merged 4 commits intomainfrom
ci/add-wsl-runners

Conversation

@leofang
Copy link
Copy Markdown
Member

@leofang leofang commented Apr 7, 2026

Summary

  • Add FLAVOR support to the Linux test workflow's runs-on field — defaults to linux but can be overridden per matrix entry (e.g. wsl)
  • Add two WSL runner entries to ci/test-matrix.yml under a new # WSL runners section:
    • py 3.11, CUDA 12.9.1, T4
    • py 3.12, CUDA 13.2.0, RTX 4090

Closes #1039

Test plan

  • Verify the WSL runners are picked up in the CI matrix
  • Confirm existing (non-WSL) runners are unaffected (no FLAVOR set → defaults to linux)
  • Run a test workflow on the WSL runners to validate end-to-end

-- Leo's bot

@copy-pr-bot
Copy link
Copy Markdown
Contributor

copy-pr-bot bot commented Apr 7, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang
Copy link
Copy Markdown
Member Author

leofang commented Apr 7, 2026

/ok to test e7fb7ef

@leofang leofang self-assigned this Apr 7, 2026
@leofang leofang added the CI/CD CI/CD infrastructure label Apr 7, 2026
@leofang
Copy link
Copy Markdown
Member Author

leofang commented Apr 8, 2026

/ok to test afbd15d

@github-actions

This comment has been minimized.

@leofang leofang requested review from cryos and rparolin April 8, 2026 00:41
@leofang
Copy link
Copy Markdown
Member Author

leofang commented Apr 8, 2026

@jrcichra it seems to just work ™️ 🎉

Q: the "latest" driver is CUDA 13.0 on WSL?

@leofang leofang added this to the cuda.core v1.0.0 milestone Apr 8, 2026
@leofang leofang marked this pull request as ready for review April 8, 2026 00:41
@leofang leofang added the P0 High priority - Must do! label Apr 8, 2026
Copy link
Copy Markdown
Collaborator

@cryos cryos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrcichra
Copy link
Copy Markdown
Collaborator

jrcichra commented Apr 8, 2026

@jrcichra it seems to just work ™️ 🎉

Q: the "latest" driver is CUDA 13.0 on WSL?

Yes, we are preinstalling this (on the Windows OS running WSL):

+-----------------------------------------------------------------------------------------+
| NVIDIA-SMI 580.126.02             Driver Version: 582.16         CUDA Version: 13.0     |
+-----------------------------------------+------------------------+----------------------+

@leofang leofang merged commit f9539c3 into main Apr 8, 2026
93 checks passed
@leofang leofang deleted the ci/add-wsl-runners branch April 8, 2026 16:09
@leofang leofang restored the ci/add-wsl-runners branch April 8, 2026 16:09
@leofang leofang deleted the ci/add-wsl-runners branch April 8, 2026 16:09
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD CI/CD infrastructure P0 High priority - Must do!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: Also test WSL

3 participants