Add Windows ARM64 build support#2312
Open
isVoid wants to merge 3 commits into
Open
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test |
|
…-bindings # Conflicts: # cuda_bindings/cuda/bindings/_bindings/loader.cpp
Contributor
Author
|
/ok to test |
Contributor
Author
|
This PR is to additionally verify that the WoA build changes does not affect the existing build system by running on the full CI matrix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
lib\arm64directory when building cuda.bindings onwin-arm64.nvcudaa64.dllfrom the Windows CUDA loader path on ARM64 builds./MACHINE:ARM64forwin-arm64.Why
These changes add native Windows ARM64 build support for cuda.bindings and the cuda.core tensor bridge AOTI shim while preserving existing x64 behavior.
Validation
pixi run python -m py_compile cuda_bindings/build_hooks.pypixi run python -m py_compile cuda_core/setup.py cuda_bindings/build_hooks.pygit diff --check -- cuda_core/setup.py cuda_bindings/build_hooks.py cuda_bindings/cuda/bindings/_bindings/loader.cpp