Revert SMResource splitting fix, the problem was the test#2321
Open
seberg wants to merge 1 commit into
Open
Conversation
2 tasks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I got things wrong, I think. While completely harmless to have the lock, I think we can consider
SMResourceas thread-unsafe as it is based ofDevice()and the green-context whereDevice()is thread-local and green-contexts are by definition thread unsafe to share.There is probably some documentation that would be good that sharing device objects across threads is unsafe (to the point of crashes). But I now think the correct fix, at least for now, is to just fix the test and I have included that here.
@Andy-Jost sorry about this but FYI since you merged the other PR for me.