Skip to content

Make canonicalization a member of sparse_binary_matrix#599

Merged
vedika-saravanan merged 3 commits into
NVIDIA:mainfrom
vedika-saravanan:ghi-582-pre-release
Jun 10, 2026
Merged

Make canonicalization a member of sparse_binary_matrix#599
vedika-saravanan merged 3 commits into
NVIDIA:mainfrom
vedika-saravanan:ghi-582-pre-release

Conversation

@vedika-saravanan

@vedika-saravanan vedika-saravanan commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR moves sparse PCM GF(2) canonicalization from the free canonicalize_pcm helper to sparse_binary_matrix::canonicalize().

Related: #582

Runtime / performance impact

N/A

Self-review checklist

Please confirm each item before requesting review. Check [x] or strike
through and explain.

Before requesting review

  • I reviewed my own full diff in GitHub or my editor.
  • PR is in Draft if it is not yet ready for review.
  • Temporary / debugging changes have been removed.
  • Local test logs reviewed; no unexplained warnings or errors.
  • CI logs reviewed; no unexplained warnings or errors.
  • Full CI has been run.

Scope and size

  • PR is under ~1000 lines, or an exception is justified in the description.
  • Refactoring-only changes are isolated in their own PR(s).
  • No existing tests were disabled or modified just to make this PR pass
    (if so, an issue has been raised).

Tests

  • New functionality has new tests.
  • Tests fail if the new functionality is broken (including crashes), not
    just when it is missing.
  • Negative tests added where exceptions are expected.
  • Truth data added where simple EXPECT_* / assert checks are
    insufficient for algorithmic correctness.
  • CI runtime impact considered; team notified if significant.

Documentation

  • Public-facing APIs have Doxygen docs.
  • User-visible behavior changes have public docs, or a follow-up is
    tracked.

Code style

  • Naming follows the existing convention (snake_case vs camelCase) for
    the area being modified.

Dependencies

  • No new third-party dependencies, or the team has been notified and
    OSRB tickets filed.

Signed-off-by: vedika-saravanan <vsaravanan@nvidia.com>
Signed-off-by: vedika-saravanan <vsaravanan@nvidia.com>
@vedika-saravanan vedika-saravanan self-assigned this Jun 9, 2026
@vedika-saravanan vedika-saravanan marked this pull request as ready for review June 9, 2026 20:09
@vedika-saravanan vedika-saravanan requested a review from bmhowe23 June 9, 2026 20:55
@vedika-saravanan vedika-saravanan merged commit a739167 into NVIDIA:main Jun 10, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants