Docs: Fix Sphinx warnings - #708
Merged
Merged
Conversation
Collaborator
Author
|
/ok to test 0c5d057 |
tlshannon
marked this pull request as ready for review
July 17, 2026 23:39
Signed-off-by: Tracy Shannon <tshannon@nvidia.com>
Signed-off-by: Tracy Shannon <tshannon@nvidia.com>
Signed-off-by: Tracy Shannon <tshannon@nvidia.com>
bmhowe23
reviewed
Jul 18, 2026
Signed-off-by: Tracy Shannon <tshannon@nvidia.com>
Signed-off-by: Tracy Shannon <tshannon@nvidia.com>
bmhowe23
reviewed
Jul 20, 2026
bmhowe23
reviewed
Jul 20, 2026
bmhowe23
left a comment
Collaborator
There was a problem hiding this comment.
The PR description is out of date with the current diffs. It claims three things that are not in the final diff: autodoc_mock_imports = ['cudaq'], manual .. class:: stubs, and setting CUDAQX_DOCS_GEN_IMPORT_CUDAQ=ON in the CMake docs target. The final approach abandoned all of these in favor of the LD_LIBRARY_PATH + real-import route (and CUDAQX_DOCS_GEN_IMPORT_CUDAQ is now referenced nowhere in the tree). Worth trimming the description so that it's accurate with the current state.
Signed-off-by: Tracy Shannon <tshannon@nvidia.com>
bmhowe23
added a commit
to kvmto/cudaqx
that referenced
this pull request
Jul 20, 2026
Resolve overlap with the merged Sphinx-warnings cleanup (NVIDIA#708): - python_api.rst: keep both the DEM Sampling autofunction section and the new _parity_check_matrix_utilities_python label (both inserted at the same spot). - core/cpp_api.rst: register cudaq::qec::dem_sampler and its ::cpu/::gpu sub-namespaces as documented targets, matching NVIDIA#708's pattern, so the DEM Sampling doxygenfunction entries no longer emit 'cpp:identifier reference target not found' warnings. - introduction.rst: align the C++ compile command with the dedicated example and the .cpp source (bare 'nvq++ -lcudaq-qec ... ' + ./a.out). ninja docs builds clean: zero Sphinx warnings, no MagicMock/alias-of/ internal-module strings in the generated HTML. Signed-off-by: Ben Howe <bhowe@nvidia.com>
cketcham2333
added a commit
to bmhowe23/cudaqx
that referenced
this pull request
Jul 23, 2026
The July 22 merge of main (9d0dfe6) brought in the cpp_realtime_decoding_api.rst additions from NVIDIA#708, which document main's config API. This branch had already renamed DecoderTransport to DecoderDispatch and moved wire selection into the server-level transport section, so Sphinx (running with -n -W) failed the Docs / Build job with five warnings. - Point the doxygenenum directive at DecoderDispatch and add directives for the new transport_config and transport_shape_override structs. - Reword the transport_shape_override doc comment so doxygen does not auto-link transport_config::device_graph; breathe emits no label for variable-member anchors, so that link would itself be a new -W failure once the struct is documented. Verified locally with the CI sphinx flags (-n -W equivalent, --keep-going): all five warnings are gone and no new warnings appear relative to the pre-fix baseline. Signed-off-by: Chuck Ketcham <cketcham@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix Sphinx documentation build warnings
Resolves all warnings produced by
sphinx-build -n --keep-goingacross the QEC, solvers, and core API docs.RST / content fixes
cpp_api.rst: sub-namespaces (decoding,decoding::config,realtime), extension macros (CUDAQ_EXTENSION_CUSTOM_CREATOR_FUNCTION*), surface-code types (surface_role,sc_orientation,vec2d),sparse_binary_matrix,graph_resources,decoder_inputs, and others.ceo,upccgsd) and fixqaoaoverload signatures insolvers/cpp_api.rst... include::) fromexclude_patternsinconf.py.into prevent duplicate domain-registration warnings.:ref:instead of:class:forstabilizer_gridandTensorNetworkDecoder; fix aplugin→pluginstypo in the TN decoder class path.nitpick_ignorefor C++ and Python types that are intentionally unresolvable (CUDA, MLIR, and cudaq types).Build infrastructure
CUDAQ_EXTENSION_CUSTOM_CREATOR_FUNCTIONand_WITH_NAMEtoPREDEFINEDinDoxyfile.inso Doxygen can parse solver observer headers without macro-expansion errors.build_docs.shthat fail the build (with distinct exit codes) ifalias of, or the internal pybind11 module name appear in any generated HTML page.Doxygen comment fixes
graph.h: add missing@param weighttograph::add_node.code.h: add missing@param optionsto bothget_codeoverloads.pcm_utils.h: add missing@param pcmto the tensor overload ofget_sorted_pcm_column_indices; add missing@param num_syndromes_per_roundtosort_pcm_columnsandsimplify_pcm.surface_code.h: suppress a spurious Doxygen auto-link oncode::get_parity_x()in a doc comment by prefixing with%.Runtime / performance impact
N/A
Self-review checklist
Please confirm each item before requesting review. Check
[x]or strikethrough and explain.
Before requesting review
Scope and size
(if so, an issue has been raised).
Tests
just when it is missing.
EXPECT_*/assertchecks areinsufficient for algorithmic correctness.
Documentation
tracked.
Code style
snake_casevscamelCase) forthe area being modified.
Dependencies
OSRB tickets filed.