Pin CMake to prevent 3.23 bugs - #10544
Merged
Merged
Conversation
vyasr
added
bug
ajschmidt8
approved these changes
Mar 30, 2022
galipremsagar
added
! - Release
and removed
! - Hotfix
Contributor
Author
|
Not sure why there's a CMake style failure here since no CMake was changed. Investigating. |
Contributor
Author
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10544 +/- ##
=============================================
Coverage 86.17% 86.17%
=============================================
Files 141 141
Lines 22510 22510
=============================================
Hits 19398 19398
Misses 3112 3112 Continue to review full report at Codecov.
|
Contributor
|
Do we also need to pin https://github.com/rapidsai/cudf/blob/branch-22.04/conda/recipes/cudf_kafka/meta.yaml# ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMake 3.23 appears to have a bug relating to CUDA support that breaks our builds.