Skip to content

Feature axes - #10979

Merged
rapids-bot[bot] merged 23 commits into
NVIDIA:branch-22.08from
VamsiTallam95:feature-axes
Jul 5, 2022
Merged

Feature axes#10979
rapids-bot[bot] merged 23 commits into
NVIDIA:branch-22.08from
VamsiTallam95:feature-axes

Conversation

@VamsiTallam95

@VamsiTallam95 VamsiTallam95 commented May 26, 2022

Copy link
Copy Markdown
Contributor

This PR closes #9592 by adding axes functionality to cudf. Return a list representing the axes of DataFrame and Series. For dataframes, it returns a list of two elements: element zero is the row index and element one is the columns. For series, it returns a list containing the row index.

@VamsiTallam95
VamsiTallam95 requested a review from a team as a code owner May 26, 2022 16:21
@github-actions github-actions Bot added the Python Affects Python cuDF API. label May 26, 2022
@VamsiTallam95 VamsiTallam95 added feature request New feature or request non-breaking Non-breaking change labels May 26, 2022
@codecov

codecov Bot commented Jun 1, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@89aa259). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.08   #10979   +/-   ##
===============================================
  Coverage                ?   86.34%           
===============================================
  Files                   ?      144           
  Lines                   ?    22737           
  Branches                ?        0           
===============================================
  Hits                    ?    19633           
  Misses                  ?     3104           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89aa259...9d91989. Read the comment docs.

brandon-b-miller
brandon-b-miller reviewed Jun 1, 2022
View reviewed changes
Comment thread python/cudf/cudf/core/dataframe.py Outdated
brandon-b-miller
brandon-b-miller reviewed Jun 1, 2022
View reviewed changes
Comment thread python/cudf/cudf/tests/test_series.py Outdated
brandon-b-miller
brandon-b-miller reviewed Jun 1, 2022
View reviewed changes
Comment thread python/cudf/cudf/tests/test_dataframe.py Outdated
@brandon-b-miller

brandon-b-miller commented Jun 1, 2022

Copy link
Copy Markdown
Contributor

This should be added to the series and dataframe docs probably under "attributes"
https://github.com/rapidsai/cudf/blob/branch-22.08/docs/cudf/source/api_docs/dataframe.rst
https://github.com/rapidsai/cudf/blob/branch-22.08/docs/cudf/source/api_docs/series.rst

brandon-b-miller
brandon-b-miller reviewed Jun 3, 2022
View reviewed changes
Comment thread python/cudf/cudf/tests/test_dataframe.py Outdated
brandon-b-miller
brandon-b-miller reviewed Jun 3, 2022
View reviewed changes
Comment thread python/cudf/cudf/core/dataframe.py Outdated
brandon-b-miller
brandon-b-miller reviewed Jun 3, 2022
View reviewed changes
Comment thread python/cudf/cudf/core/dataframe.py Outdated
brandon-b-miller
brandon-b-miller reviewed Jun 3, 2022
View reviewed changes
Comment thread python/cudf/cudf/core/series.py Outdated
brandon-b-miller
brandon-b-miller reviewed Jun 3, 2022
View reviewed changes
Comment thread python/cudf/cudf/core/series.py Outdated
brandon-b-miller
brandon-b-miller reviewed Jun 3, 2022
View reviewed changes
Comment thread python/cudf/cudf/core/series.py Outdated
@VamsiTallam95 VamsiTallam95 mentioned this pull request Jun 8, 2022
Closed
@VamsiTallam95

VamsiTallam95 commented Jun 15, 2022

Copy link
Copy Markdown
Contributor Author

rerun tests

brandon-b-miller
brandon-b-miller reviewed Jun 16, 2022
View reviewed changes
Comment thread python/cudf/cudf/core/dataframe.py
brandon-b-miller
brandon-b-miller reviewed Jun 21, 2022
View reviewed changes
Comment thread python/cudf/cudf/core/dataframe.py Outdated
brandon-b-miller
brandon-b-miller reviewed Jun 21, 2022
View reviewed changes
Comment thread python/cudf/cudf/core/series.py Outdated
VamsiTallam95 and others added 2 commits June 21, 2022 09:11
@VamsiTallam95 @brandon-b-miller
Update python/cudf/cudf/core/dataframe.py
70fada8 
Co-authored-by: brandon-b-miller <53796099+brandon-b-miller@users.noreply.github.com>
@VamsiTallam95 @brandon-b-miller
Update python/cudf/cudf/core/series.py
41a1306 
Co-authored-by: brandon-b-miller <53796099+brandon-b-miller@users.noreply.github.com>
@VamsiTallam95

VamsiTallam95 commented Jun 22, 2022

Copy link
Copy Markdown
Contributor Author

rerun tests

brandon-b-miller
brandon-b-miller approved these changes Jun 22, 2022
View reviewed changes

@brandon-b-miller brandon-b-miller left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM unless @vyasr has any thoughts.

vyasr
vyasr requested changes Jun 23, 2022
View reviewed changes

@vyasr vyasr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got a few minor suggestions for improvement. Nothing major, but there are enough that I think it's worth going back to address them. They should be quick, let me know if anything is confusing though.

Comment thread python/cudf/cudf/core/dataframe.py
Comment thread python/cudf/cudf/core/series.py Outdated
Comment thread python/cudf/cudf/tests/test_dataframe.py Outdated
Comment thread python/cudf/cudf/tests/test_series.py Outdated
Comment thread python/cudf/cudf/tests/test_dataframe.py Outdated
Comment thread python/cudf/cudf/tests/test_series.py Outdated
VamsiTallam95 and others added 5 commits June 22, 2022 18:02
@VamsiTallam95 @vyasr
Update python/cudf/cudf/core/series.py
5b673ba 
Co-authored-by: Vyas Ramasubramani <vyas.ramasubramani@gmail.com>
@VamsiTallam95 @vyasr
Update python/cudf/cudf/tests/test_dataframe.py
3078034 
Co-authored-by: Vyas Ramasubramani <vyas.ramasubramani@gmail.com>
@VamsiTallam95 @vyasr
Update python/cudf/cudf/tests/test_dataframe.py
1fffc61 
Co-authored-by: Vyas Ramasubramani <vyas.ramasubramani@gmail.com>
@VamsiTallam95 @vyasr
Update python/cudf/cudf/tests/test_series.py
a8abfb5 
Co-authored-by: Vyas Ramasubramani <vyas.ramasubramani@gmail.com>
@VamsiTallam95 @vyasr
Update python/cudf/cudf/tests/test_series.py
9d91989 
Co-authored-by: Vyas Ramasubramani <vyas.ramasubramani@gmail.com>
@VamsiTallam95
VamsiTallam95 requested a review from vyasr June 27, 2022 17:06
@vyasr

vyasr commented Jul 5, 2022

Copy link
Copy Markdown
Contributor

@gpucibot merge

@rapids-bot
rapids-bot Bot merged commit e977538 into NVIDIA:branch-22.08 Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vyasr vyasr vyasr approved these changes
@brandon-b-miller brandon-b-miller brandon-b-miller approved these changes

Assignees

No one assigned

Labels

feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEA] Series and DataFrame.axes

4 participants

@VamsiTallam95 @brandon-b-miller @vyasr @caryr35