Remove deprecated Index methods from Frame - #11073
Conversation
vyasr
added
3 - Ready for Review
bdice
left a comment
bdice
left a comment
There was a problem hiding this comment.
LGTM. I verified that this is a trivial move of the existing code into classes where it fits better. I am leaving this review pretty minimal since the sole purpose of this PR is to clean up where methods are defined -- I'm leaving any improvements to those methods out of the scope of this PR. Thanks @vyasr for this!
|
Blocked on #11070 |
|
rerun tests |
1 similar comment
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-22.08 #11073 +/- ##
===============================================
Coverage ? 86.33%
===============================================
Files ? 144
Lines ? 22729
Branches ? 0
===============================================
Hits ? 19624
Misses ? 3105
Partials ? 0 Continue to review full report at Codecov.
|
|
@gpucibot merge |
This PR is a follow-up to #11073. Its sole purpose is to remove the deprecated public `replace` API for Index objects. A stripped down, minimal version of this logic has been inlined in `DataFrame.rename`, which is the only place that needs that functionality. The scope of this PR is intentionally limited so that further changes can happen in parallel with changes associated with the removal of `Frame._index`, which should no longer be necessary after this PR is merged (aside from its potential usage in internal Cython code that can be freely worked around). Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Ashwin Srinath (https://github.com/shwina) URL: #11131
3 participants
This PR moves a number of methods from Frame to IndexedFrame that are no longer supported for Index objects. The one holdout is
Frame.replace, which is also deprecated for Index but is used internally by Index methods in one place. In order to make this PR as simple to review as possible, I have omitted that function here. All changes in this PR are trivial moves of code aside from the deletions of the warnings.