Fix regex word boundary logic to include underline - #11099
Merged
rapids-bot[bot] merged 8 commits intoJun 28, 2022
Conversation
davidwendt
added
bug
Codecov Report
@@ Coverage Diff @@
## branch-22.08 #11099 +/- ##
===============================================
Coverage ? 86.32%
===============================================
Files ? 144
Lines ? 22751
Branches ? 0
===============================================
Hits ? 19640
Misses ? 3111
Partials ? 0 Continue to review full report at Codecov.
|
davidwendt
added
3 - Ready for Review
davidwendt
marked this pull request as ready for review
June 21, 2022 20:45
robertmaynard
approved these changes
Jun 22, 2022
bdice
approved these changes
Jun 27, 2022
bdice
left a comment
bdice
left a comment
Contributor
There was a problem hiding this comment.
The well-written PR description made this review easy. Thanks!
ramakrishnap-nv
approved these changes
Jun 27, 2022
Contributor
Author
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11062
The regex logic handling word boundary (identified by
\band\B) did not include the_underline character as defined for word characters by https://www.regular-expressions.info/shorthand.html. This PR fixes this by using the logic for identifying word characters from theCCLASS_Wspecifier (identified by\w).Also, the word-boundary test cases are updated to include tests with the
_character as well as tests with\B.