Skip to content

Returns DataFrame When Concating Along Axis 1 - #11263

Merged
rapids-bot[bot] merged 2 commits into
NVIDIA:branch-22.08from
isVoid:bug/axis1_concat
Jul 14, 2022
Merged

Returns DataFrame When Concating Along Axis 1#11263
rapids-bot[bot] merged 2 commits into
NVIDIA:branch-22.08from
isVoid:bug/axis1_concat

Conversation

@isVoid

@isVoid isVoid commented Jul 14, 2022

Copy link
Copy Markdown
Contributor

fixes #11244

When concatenating along axis 1, pandas always return a dataframe even though there are only 1 column involved. This PR conforms cuDF to that behavior.

@isVoid
isVoid requested a review from a team as a code owner July 14, 2022 00:49
@isVoid
isVoid requested review from ramakrishnap-nv and vyasr July 14, 2022 00:49
@github-actions github-actions Bot added the Python Affects Python cuDF API. label Jul 14, 2022
Comment thread python/cudf/cudf/tests/test_concat.py Outdated
@codecov

codecov Bot commented Jul 14, 2022

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@99eaaef). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.08   #11263   +/-   ##
===============================================
  Coverage                ?   86.31%           
===============================================
  Files                   ?      144           
  Lines                   ?    22753           
  Branches                ?        0           
===============================================
  Hits                    ?    19640           
  Misses                  ?     3113           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99eaaef...b6c6913. Read the comment docs.

@galipremsagar galipremsagar added bug Something isn't working 5 - Ready to Merge Testing and reviews complete, ready to merge non-breaking Non-breaking change labels Jul 14, 2022
@galipremsagar

Copy link
Copy Markdown
Contributor

@gpucibot merge

@rapids-bot
rapids-bot Bot merged commit 9034b1b into NVIDIA:branch-22.08 Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG?] concat([<Series>], axis=1) results in a series, not a dataframe

2 participants