Consolidate remaining DataFrame/Series APIs - #11315
Merged
rapids-bot[bot] merged 5 commits intoJul 26, 2022
Merged
Conversation
vyasr
added
3 - Ready for Review
mroeschke
approved these changes
Jul 22, 2022
Contributor
Author
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-22.08 #11315 +/- ##
===============================================
Coverage ? 86.40%
===============================================
Files ? 143
Lines ? 22756
Branches ? 0
===============================================
Hits ? 19662
Misses ? 3094
Partials ? 0 Continue to review full report at Codecov.
|
Contributor
Author
|
@gpucibot merge |
bdice
approved these changes
Jul 26, 2022
bdice
left a comment
bdice
left a comment
Contributor
There was a problem hiding this comment.
One quibble about dedent. Otherwise LGTM!
|
|
||
|
|
||
| class GroupBy(Serializable, Reducible, Scannable): | ||
| groupby_doc_template = textwrap.dedent( |
Contributor
There was a problem hiding this comment.
Isn't the point of using dedent so that you can write it in a nicely indented way? (The catch is to escape the first newline iirc.)
groupby_doc_template = textwrap.dedent("""\
Group using a mapper or by a Series of columns.
A groupby operation involves...
Parameters
----------
by : ...
"""
Contributor
|
@vyasr I was 3 minutes too slow! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #9038. Not all the remaining functions could be consolidated (for various reasons), but the combination was explored and where necessary the reasons not to combine the functions was documented in that issue. Some additional cleanup that was done during the exploration is also included in this PR, but ultimately
groupbyis the only method that was moved up toIndexedFrame.