Skip to content

Add libcudf strings examples - #11849

Merged
rapids-bot[bot] merged 15 commits into
NVIDIA:branch-22.12from
davidwendt:example-strings
Oct 14, 2022
Merged

Add libcudf strings examples#11849
rapids-bot[bot] merged 15 commits into
NVIDIA:branch-22.12from
davidwendt:example-strings

Conversation

@davidwendt

Copy link
Copy Markdown
Contributor

Description

Creates example for calling libcudf APIs for strings processing.
This also includes examples of building custom kernels for modifying libcudf strings columns.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 3, 2022
@davidwendt davidwendt self-assigned this Oct 3, 2022
@github-actions github-actions Bot added CMake CMake build issue gpuCI labels Oct 3, 2022
@codecov

codecov Bot commented Oct 3, 2022

Copy link
Copy Markdown

Codecov Report

Base: 87.40% // Head: 86.85% // Decreases project coverage by -0.55% ⚠️

Coverage data is based on head (ad65d40) compared to base (f72c4ce).
Patch coverage: 86.52% of modified lines in pull request are covered.

❗ Current head ad65d40 differs from pull request most recent head d95708e. Consider uploading reports for the commit d95708e to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #11849      +/-   ##
================================================
- Coverage         87.40%   86.85%   -0.56%     
================================================
  Files               133      133              
  Lines             21833    21881      +48     
================================================
- Hits              19084    19005      -79     
- Misses             2749     2876     +127     
Impacted Files Coverage Δ
python/cudf/cudf/core/udf/__init__.py 50.00% <ø> (ø)
python/cudf/cudf/io/orc.py 92.94% <ø> (-0.09%) ⬇️
...thon/dask_cudf/dask_cudf/tests/test_distributed.py 18.86% <ø> (+4.94%) ⬆️
python/cudf/cudf/core/_base_index.py 82.20% <43.75%> (-3.35%) ⬇️
python/cudf/cudf/io/text.py 91.66% <66.66%> (-8.34%) ⬇️
python/strings_udf/strings_udf/__init__.py 84.31% <76.00%> (-12.57%) ⬇️
python/cudf/cudf/core/index.py 92.91% <95.16%> (+0.28%) ⬆️
python/cudf/cudf/__init__.py 90.69% <100.00%> (ø)
python/cudf/cudf/core/column/categorical.py 89.34% <100.00%> (ø)
python/cudf/cudf/core/groupby/groupby.py 91.30% <100.00%> (+0.08%) ⬆️
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davidwendt davidwendt changed the title Add libcudf strings example Add libcudf strings examples Oct 4, 2022
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Oct 6, 2022
@davidwendt
davidwendt marked this pull request as ready for review October 6, 2022 13:41
@davidwendt
davidwendt requested review from a team as code owners October 6, 2022 13:41

@bdice bdice left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the blog post as well, so this code was quick to review. Nice example!

Comment thread cpp/examples/strings/CMakeLists.txt
Comment thread cpp/examples/strings/common.hpp Outdated
Comment thread cpp/examples/strings/common.hpp Outdated
Comment thread cpp/examples/strings/common.hpp Outdated

@nvdbaranec nvdbaranec left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these comments are along the line of : I'm assuming this is also partially useful as a cuda explainer. If the intended audience here is more advanced, they may not be useful.

Comment thread cpp/examples/strings/custom_optimized.cu
Comment thread cpp/examples/strings/custom_optimized.cu
Comment thread cpp/examples/strings/custom_optimized.cu
Comment thread cpp/examples/strings/custom_optimized.cu Outdated
Comment thread cpp/examples/strings/libcudf_apis.cpp
Comment thread cpp/examples/strings/custom_with_malloc.cu
Comment thread cpp/examples/strings/custom_with_malloc.cu Outdated
Comment thread cpp/examples/strings/CMakeLists.txt Outdated

@msadang msadang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidwendt

Copy link
Copy Markdown
Contributor Author

@gpucibot merge

@rapids-bot
rapids-bot Bot merged commit 7598253 into NVIDIA:branch-22.12 Oct 14, 2022
@davidwendt
davidwendt deleted the example-strings branch October 14, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants