Skip to content

[REVIEW] Error on ListColumn or any new unsupported column in cudf.Index - #11902

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:branch-22.12from
galipremsagar:list_index_error
Oct 11, 2022
Merged

[REVIEW] Error on ListColumn or any new unsupported column in cudf.Index#11902
rapids-bot[bot] merged 1 commit into
NVIDIA:branch-22.12from
galipremsagar:list_index_error

Conversation

@galipremsagar

@galipremsagar galipremsagar commented Oct 11, 2022

Copy link
Copy Markdown
Contributor

Description

This PR raises a NotImplementedError for ListColumn or any new column that isn't supported by cudf.Index yet.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 11, 2022
@galipremsagar galipremsagar self-assigned this Oct 11, 2022
@galipremsagar
galipremsagar requested a review from a team as a code owner October 11, 2022 15:15
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Oct 11, 2022
@galipremsagar

Copy link
Copy Markdown
Contributor Author

rerun tests

@codecov

codecov Bot commented Oct 11, 2022

Copy link
Copy Markdown

Codecov Report

Base: 87.40% // Head: 87.48% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (4386067) compared to base (f72c4ce).
Patch coverage: 84.16% of modified lines in pull request are covered.

❗ Current head 4386067 differs from pull request most recent head a85286e. Consider uploading reports for the commit a85286e to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #11902      +/-   ##
================================================
+ Coverage         87.40%   87.48%   +0.07%     
================================================
  Files               133      133              
  Lines             21833    21865      +32     
================================================
+ Hits              19084    19129      +45     
+ Misses             2749     2736      -13     
Impacted Files Coverage Δ
python/cudf/cudf/core/udf/__init__.py 50.00% <ø> (ø)
python/cudf/cudf/io/orc.py 92.94% <ø> (-0.09%) ⬇️
python/cudf/cudf/utils/ioutils.py 79.47% <ø> (ø)
...thon/dask_cudf/dask_cudf/tests/test_distributed.py 18.86% <ø> (+4.94%) ⬆️
python/cudf/cudf/core/_base_index.py 82.20% <43.75%> (-3.35%) ⬇️
python/cudf/cudf/io/text.py 91.66% <66.66%> (-8.34%) ⬇️
python/strings_udf/strings_udf/__init__.py 86.27% <76.00%> (-10.61%) ⬇️
python/cudf/cudf/core/index.py 92.91% <95.16%> (+0.28%) ⬆️
python/cudf/cudf/__init__.py 90.69% <100.00%> (ø)
python/cudf/cudf/core/column/categorical.py 89.34% <100.00%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@galipremsagar

Copy link
Copy Markdown
Contributor Author

@gpucibot merge

@rapids-bot
rapids-bot Bot merged commit a921f5d into NVIDIA:branch-22.12 Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants