Skip to content

Minor cleanup of root CMakeLists.txt for better organization - #11988

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:branch-22.12from
robertmaynard:cleanup-root-cmakelists
Oct 25, 2022
Merged

Minor cleanup of root CMakeLists.txt for better organization#11988
rapids-bot[bot] merged 1 commit into
NVIDIA:branch-22.12from
robertmaynard:cleanup-root-cmakelists

Conversation

@robertmaynard

Copy link
Copy Markdown
Contributor

Description

Cleanup some minor issues in the root cudf CMakeLists.txt. Make the seaching for CUDA_SANITIZER only occur when we are building tests as that doesn't need to be done for production builds.

Move the gdb pretty print script logic to a separate region to better document what it is for.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@robertmaynard robertmaynard added feature request New feature or request 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Oct 25, 2022
@robertmaynard
robertmaynard requested a review from a team as a code owner October 25, 2022 16:58
@github-actions github-actions Bot added CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. labels Oct 25, 2022
@robertmaynard

Copy link
Copy Markdown
Contributor Author

@gpucibot merge

@codecov

codecov Bot commented Oct 25, 2022

Copy link
Copy Markdown

Codecov Report

Base: 87.40% // Head: 86.90% // Decreases project coverage by -0.50% ⚠️

Coverage data is based on head (83a0cb6) compared to base (f72c4ce).
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #11988      +/-   ##
================================================
- Coverage         87.40%   86.90%   -0.51%     
================================================
  Files               133      133              
  Lines             21833    21995     +162     
================================================
+ Hits              19084    19114      +30     
- Misses             2749     2881     +132     
Impacted Files Coverage Δ
python/strings_udf/strings_udf/lowering.py 0.00% <0.00%> (-84.40%) ⬇️
python/strings_udf/strings_udf/_typing.py 81.05% <0.00%> (-14.74%) ⬇️
python/strings_udf/strings_udf/__init__.py 84.31% <0.00%> (-12.57%) ⬇️
python/cudf/cudf/io/text.py 91.66% <0.00%> (-8.34%) ⬇️
python/cudf/cudf/core/_base_index.py 82.20% <0.00%> (-3.35%) ⬇️
python/cudf/cudf/core/column/lists.py 92.78% <0.00%> (-0.97%) ⬇️
python/cudf/cudf/testing/dataset_generator.py 72.83% <0.00%> (-0.42%) ⬇️
python/dask_cudf/dask_cudf/backends.py 84.90% <0.00%> (-0.37%) ⬇️
python/cudf/cudf/core/tools/datetimes.py 84.19% <0.00%> (-0.31%) ⬇️
python/dask_cudf/dask_cudf/core.py 73.92% <0.00%> (-0.21%) ⬇️
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rapids-bot
rapids-bot Bot merged commit 6a5c77b into NVIDIA:branch-22.12 Oct 25, 2022
@robertmaynard
robertmaynard deleted the cleanup-root-cmakelists branch October 25, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 - Ready for Review Ready for review by team CMake CMake build issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants