[REVIEW] Reduce/Remove reliance on **kwargs and *args in IO readers & writers - #12025
Merged
Conversation
galipremsagar
added
bug
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
Contributor
Author
|
@bdice Should be ready for another round of review. |
Contributor
|
This pr also fixes #6916 |
wence-
reviewed
Nov 1, 2022
wence-
reviewed
Nov 1, 2022
wence-
approved these changes
Nov 1, 2022
wence-
left a comment
wence-
left a comment
Contributor
There was a problem hiding this comment.
Two very minor niggles, but otherwise looks great, thanks for this!
bdice
approved these changes
Nov 1, 2022
bdice
left a comment
bdice
left a comment
Contributor
There was a problem hiding this comment.
A few minor suggestions, otherwise LGTM. Thank you for the iterations!
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
3 tasks
galipremsagar
added
5 - Ready to Merge
Contributor
Author
|
@gpucibot merge |
Contributor
Author
rapids-bot Bot
pushed a commit
that referenced
this pull request
Nov 1, 2022
This PR removes all "smart quotes" from the library by enforcing a pre-commit hook. Smart quotes typically arise from copying rendered docstrings from Pandas, because Sphinx automatically transforms straight quotes into smart quotes when rendering the docs as HTML. However, the use of smart quotes is undesirable in code, and makes it difficult to do find-replace transformations if straight and smart quotes are mixed. I have made suggestions to fix this several times before, so I am making the suggestions more permanent and automatically enforceable via a pre-commit style check: - #12025 (comment) - #9817 (comment) - #9571 (comment) Authors: - Bradley Dice (https://github.com/bdice) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) URL: #12035
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves: #11780
This PR:
args&kwargsfor readers and writers whencudfengine is selected. However, these will have to stay for the purpose of other engines we support in few readers & writers such aspandas&pyarrowengines.Checklist