Skip to content

[REVIEW] Fix an error in IO with GzipFile type - #12085

Merged
rapids-bot[bot] merged 4 commits into
NVIDIA:branch-22.12from
galipremsagar:10590
Nov 9, 2022
Merged

[REVIEW] Fix an error in IO with GzipFile type#12085
rapids-bot[bot] merged 4 commits into
NVIDIA:branch-22.12from
galipremsagar:10590

Conversation

@galipremsagar

Copy link
Copy Markdown
Contributor

Description

Fixes: #10590

This PR fixes an issue where the file-like object doesn't have a size attribute, we will manually compute the size of the file.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Nov 7, 2022
@galipremsagar galipremsagar self-assigned this Nov 7, 2022
@galipremsagar
galipremsagar requested a review from a team as a code owner November 7, 2022 16:42
@codecov

codecov Bot commented Nov 7, 2022

Copy link
Copy Markdown

Codecov Report

Base: 87.47% // Head: 88.08% // Increases project coverage by +0.61% 🎉

Coverage data is based on head (2b10aa3) compared to base (f817d96).
Patch has no changes to coverable lines.

❗ Current head 2b10aa3 differs from pull request most recent head bbdfe90. Consider uploading reports for the commit bbdfe90 to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #12085      +/-   ##
================================================
+ Coverage         87.47%   88.08%   +0.61%     
================================================
  Files               133      135       +2     
  Lines             21826    22063     +237     
================================================
+ Hits              19093    19435     +342     
+ Misses             2733     2628     -105     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/interval.py 85.45% <0.00%> (-9.10%) ⬇️
python/cudf/cudf/io/text.py 91.66% <0.00%> (-8.34%) ⬇️
python/strings_udf/strings_udf/__init__.py 76.47% <0.00%> (-7.85%) ⬇️
python/cudf/cudf/core/_base_index.py 81.28% <0.00%> (-4.27%) ⬇️
python/cudf/cudf/io/json.py 92.06% <0.00%> (-2.68%) ⬇️
python/cudf/cudf/utils/utils.py 89.91% <0.00%> (-0.69%) ⬇️
python/cudf/cudf/core/column/timedelta.py 90.17% <0.00%> (-0.58%) ⬇️
python/cudf/cudf/core/column/datetime.py 89.21% <0.00%> (-0.51%) ⬇️
python/cudf/cudf/core/column/column.py 87.96% <0.00%> (-0.46%) ⬇️
python/dask_cudf/dask_cudf/core.py 73.72% <0.00%> (-0.41%) ⬇️
... and 42 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Comment thread python/cudf/cudf/utils/ioutils.py
@galipremsagar
galipremsagar requested a review from vuule November 9, 2022 14:58
Comment thread python/cudf/cudf/utils/ioutils.py Outdated
Co-authored-by: brandon-b-miller <53796099+brandon-b-miller@users.noreply.github.com>
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Nov 9, 2022
@galipremsagar

Copy link
Copy Markdown
Contributor Author

@gpucibot merge

@rapids-bot
rapids-bot Bot merged commit a2c428c into NVIDIA:branch-22.12 Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Fail to read_json from GzipFile

3 participants