[HOTFIX] strings_udf: use libcudf caching of character tables - #12343
Merged
Conversation
wence-
added
bug
We can't build the table pointers at import time, since that creates a cuda context. Since libcudf caches these instances internally, just call the functions directly. Closes NVIDIA#12340.
wence-
force-pushed
the
wence/fix/issue-12340
branch
from
December 8, 2022 15:51
a56bf84 to
755c575
Compare
shwina
changed the title
wence-
changed the title
wence-
changed the title
shwina
approved these changes
Dec 8, 2022
Codecov ReportBase: 88.22% // Head: 88.23% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #12343 +/- ##
================================================
+ Coverage 88.22% 88.23% +0.01%
================================================
Files 137 137
Lines 22571 22568 -3
================================================
Hits 19914 19914
+ Misses 2657 2654 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We can't build the table pointers at import time, since that creates a
cuda context. Since libcudf caches these instances internally, just
call the functions directly.
Closes #12340.
Checklist