Preserve names of column object in various APIs - #13772
Merged
rapids-bot[bot] merged 6 commits intoJul 28, 2023
Merged
Conversation
galipremsagar
added
bug
galipremsagar
changed the title
galipremsagar
changed the title
mroeschke
reviewed
Jul 26, 2023
shwina
reviewed
Jul 27, 2023
3 tasks
bdice
approved these changes
Jul 27, 2023
bdice
left a comment
bdice
left a comment
Contributor
There was a problem hiding this comment.
A few small comments but nothing blocking. LGTM!
shwina
approved these changes
Jul 28, 2023
galipremsagar
added
5 - Ready to Merge
wence-
approved these changes
Jul 28, 2023
wence-
left a comment
wence-
left a comment
Contributor
There was a problem hiding this comment.
One small comment, but I think this makes sense.
Although, the index alignment is pretty hairy...
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR preserves column names in various APIs by retaining
self._data._level_namesand also calculating when to preserve the column names.Fixes: #13741, #13740
Checklist