Raise NotImplementedError for pd.SparseDtype - #13798
Merged
rapids-bot[bot] merged 6 commits intoAug 3, 2023
Merged
Conversation
mroeschke
added
improvement
bdice
approved these changes
Aug 1, 2023
bdice
left a comment
bdice
left a comment
Contributor
There was a problem hiding this comment.
Please write a description for this PR, otherwise LGTM.
galipremsagar
approved these changes
Aug 2, 2023
mroeschke
commented
Aug 3, 2023
mroeschke
commented
Aug 3, 2023
Contributor
Author
|
Failures have been addressed now |
Contributor
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently cuDF seems to cast
pd.SparseDtypeto it's subtype instead of maintaining the sparse data type from pandas. Sincepd.SparseDtypeis not supported in cuDF, it is better to raise and tell users to cast directly to the sparse subtypeChecklist
As discussed with @shwina, this should raise in cuDF