Skip to content

Remove hangs from trying to construct un-bounded sequences - #13799

Merged
rapids-bot[bot] merged 5 commits into
NVIDIA:branch-23.10from
galipremsagar:13049
Aug 2, 2023
Merged

Remove hangs from trying to construct un-bounded sequences#13799
rapids-bot[bot] merged 5 commits into
NVIDIA:branch-23.10from
galipremsagar:13049

Conversation

@galipremsagar

Copy link
Copy Markdown
Contributor

Description

Fixes: #13049
This PR allows errors from pyarrow to be propagated when an un-bounded sequence is passed to pa.array constructor.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Aug 1, 2023
@galipremsagar
galipremsagar requested review from bdice and shwina August 1, 2023 23:45
@galipremsagar galipremsagar self-assigned this Aug 1, 2023
@galipremsagar
galipremsagar requested a review from a team as a code owner August 1, 2023 23:45

@bdice bdice left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isort probably wants you to move the collections import up -- but otherwise this change looks good to me. Thank you so much for picking this up, Ashwin and I discussed this extensively in the corresponding issue 😄

@galipremsagar

Copy link
Copy Markdown
Contributor Author

isort probably wants you to move the collections import up -- but otherwise this change looks good to me. Thank you so much for picking this up, Ashwin and I discussed this extensively in the corresponding issue 😄

Fixed it 👍 Thanks @bdice !

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Aug 2, 2023
@galipremsagar

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit 5e8fd8e into NVIDIA:branch-23.10 Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Constructing from an unbound sequence doesn't raise/hangs

2 participants