Skip to content

Fix any, all reduction behavior for axis=None and warn for other reductions - #13831

Merged
rapids-bot[bot] merged 15 commits into
NVIDIA:branch-23.10from
galipremsagar:13827
Aug 9, 2023
Merged

Fix any, all reduction behavior for axis=None and warn for other reductions#13831
rapids-bot[bot] merged 15 commits into
NVIDIA:branch-23.10from
galipremsagar:13827

Conversation

@galipremsagar

@galipremsagar galipremsagar commented Aug 8, 2023

Copy link
Copy Markdown
Contributor

Description

Fixes: #13827

This PR:

  • Fixes axis=None behavior for any & all reductions.
  • Introduces FutureWarning for upcoming change in behavior for the rest of the reductions since some of the reductions are only updated in pandas-2.0 and the rest would be updated in pandas-3.0.
  • Fixed numpy array function inconsistency because of mismatching default for axis parameter.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions Bot added the Python Affects Python cuDF API. label Aug 8, 2023
@galipremsagar galipremsagar changed the title Add futurewarning to all reductions Fix any, all reduction behavior for axis=None and warn for other reductions Aug 8, 2023
@galipremsagar galipremsagar self-assigned this Aug 8, 2023
@galipremsagar
galipremsagar marked this pull request as ready for review August 8, 2023 19:03
@galipremsagar
galipremsagar requested a review from a team as a code owner August 8, 2023 19:03
@galipremsagar
galipremsagar requested review from isVoid and wence- August 8, 2023 19:03
@galipremsagar galipremsagar added the bug Something isn't working label Aug 8, 2023
Comment thread python/cudf/cudf/core/dataframe.py Outdated
Comment thread python/cudf/cudf/core/frame.py Outdated
Comment thread python/cudf/cudf/tests/test_array_function.py
galipremsagar and others added 2 commits August 8, 2023 16:26
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@galipremsagar
galipremsagar requested a review from bdice August 8, 2023 22:10
Comment thread python/cudf/cudf/core/dataframe.py Outdated
@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Aug 9, 2023
@galipremsagar

Copy link
Copy Markdown
Contributor Author

/merge

1 similar comment
@galipremsagar

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit edb25a8 into NVIDIA:branch-23.10 Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 - Ready to Merge Testing and reviews complete, ready to merge breaking Breaking change bug Something isn't working Python Affects Python cuDF API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] np.all doesn't perform logical AND over all dimensions when axis=None

2 participants