Add nvtext::tokenize_with_vocabulary API - #13930
Merged
rapids-bot[bot] merged 33 commits intoSep 26, 2023
Merged
Conversation
davidwendt
marked this pull request as ready for review
August 23, 2023 18:50
robertmaynard
approved these changes
Aug 23, 2023
robertmaynard
left a comment
Contributor
There was a problem hiding this comment.
Approving CMake changes
nvdbaranec
suggested changes
Aug 24, 2023
nvdbaranec
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Just a couple of tiny things.
davidwendt
marked this pull request as draft
August 28, 2023 19:20
davidwendt
marked this pull request as ready for review
September 7, 2023 17:44
nvdbaranec
approved these changes
Sep 12, 2023
bdice
reviewed
Sep 19, 2023
bdice
left a comment
Contributor
There was a problem hiding this comment.
Feedback attached. The cuco static map is truly awesome. 👍
3 tasks
rapids-bot Bot
pushed a commit
that referenced
this pull request
Sep 25, 2023
…14163) Moves `cpp/src/hash/hash_allocator.cuh` to `include/cudf/hashing/detail` so it may be more accessible from non-src/hash source files. Also, found `cpp/src/hash/helper_functions.hpp` used in the same way a moved that one as well. No functional changes, just headers moved and includes fixed up. Reference: #13930 (comment) Closes #14143 Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Yunsong Wang (https://github.com/PointKernel) - Vyas Ramasubramani (https://github.com/vyasr) URL: #14163
bdice
approved these changes
Sep 26, 2023
bdice
left a comment
Contributor
There was a problem hiding this comment.
One suggestion, otherwise LGTM.
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds tokenize with vocabulary APIs to libcudf.
Returns an integer lists column replacing individual tokens as resolved from the
inputusingdelimiterwith id values which are the row indices of the inputvocabularycolumn.If a token is not found in the
vocabularyit is assigneddefault_id.The vocabulary can be loaded once using the
nvtext::load_vocabulary()API and then used in repeated calls tonvtext::tokenize_with_vocabulary()with different input columns.Python interface is new class
TokenizeVocabularywhich can be used like the following:Checklist