Skip to content

Fix index of Groupby.apply results when it is performed on empty objects - #13944

Merged
rapids-bot[bot] merged 6 commits into
NVIDIA:branch-23.10from
galipremsagar:13939
Aug 23, 2023
Merged

Fix index of Groupby.apply results when it is performed on empty objects#13944
rapids-bot[bot] merged 6 commits into
NVIDIA:branch-23.10from
galipremsagar:13939

Conversation

@galipremsagar

Copy link
Copy Markdown
Contributor

Description

closes #13939
This PR fixes two issues with Groupby.apply, where the index of the result was not being set correctly and there is a corner case for bool dtype that has to be handled for sum & product operations.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Aug 23, 2023
@galipremsagar
galipremsagar requested a review from a team as a code owner August 23, 2023 19:53
@galipremsagar galipremsagar self-assigned this Aug 23, 2023
Comment thread python/cudf/cudf/core/groupby/groupby.py Outdated
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Aug 23, 2023
@galipremsagar

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit 171fc91 into NVIDIA:branch-23.10 Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Index of empty objects not set in Groupby.apply

2 participants