Fix an issue where casting null-array to object dtype will result in a failure - #13994
Merged
Conversation
galipremsagar
added
3 - Ready for Review
galipremsagar
marked this pull request as ready for review
August 29, 2023 16:29
Contributor
Author
|
/ok to test |
mroeschke
reviewed
Aug 29, 2023
galipremsagar
added
improvement
bdice
approved these changes
Aug 30, 2023
galipremsagar
added
5 - Ready to Merge
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #13992
This PR fixes the construction of an empty
MultiIndexfrompandastocudfwas causing an error in pandas-compatibility mode, null-array is one such case where it is okay to cast to any type because there is no data in it. Hence we passstrdtype toastype, whenever we encounter anobjectdtype.Checklist