Explicitly depend on zlib in conda recipes - #14018
Conversation
We were previously obtaining zlib transitively through our cmake dependency, but since the 3.27.4 conda package, this dependency no longer exists. Therefore we must depend on zlib ourselves.
| - c-compiler | ||
| - cxx-compiler | ||
| - dlpack>=0.5,<0.6.0a0 | ||
| - zlib |
There was a problem hiding this comment.
@wence- Can you comment on where/how we use zlib? Does it need to be in the conda package dependencies (meta.yml for libcudf, or cudf, …) as well?
There was a problem hiding this comment.
Is there an issue documenting the problems you see in builds?
There was a problem hiding this comment.
We support zlib compression/decompression in ORC reading/writing, so we should be including it in our recipe.
bdice
left a comment
There was a problem hiding this comment.
Thanks for the fix, this looks right to me.
ajschmidt8
left a comment
There was a problem hiding this comment.
Approving ops-codeowner file changes
I'm pretty sure we go back quite a bit and have the same API available. I'm looking at their changelog, and there are bug fixes in every release. Based on this, should we make 1.2.13 the lower bound? It was released Oct 2022. |
Done. |
vyasr
left a comment
There was a problem hiding this comment.
Lower bound looks reasonable to me.
|
/merge |
Description
We were previously obtaining zlib transitively through our cmake dependency, but since the 3.27.4 conda package, this dependency no longer exists. Therefore we must depend on zlib ourselves.
zlibpackage #14021Checklist