Skip to content

Explicitly depend on zlib in conda recipes - #14018

Merged
rapids-bot[bot] merged 4 commits into
NVIDIA:branch-23.10from
wence-:wence/fix/depend-zlib-explicit
Aug 31, 2023
Merged

Explicitly depend on zlib in conda recipes#14018
rapids-bot[bot] merged 4 commits into
NVIDIA:branch-23.10from
wence-:wence/fix/depend-zlib-explicit

Conversation

@wence-

@wence- wence- commented Aug 31, 2023

Copy link
Copy Markdown
Contributor

Description

We were previously obtaining zlib transitively through our cmake dependency, but since the 3.27.4 conda package, this dependency no longer exists. Therefore we must depend on zlib ourselves.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

We were previously obtaining zlib transitively through our cmake
dependency, but since the 3.27.4 conda package, this dependency no
longer exists. Therefore we must depend on zlib ourselves.
@wence-
wence- requested a review from a team as a code owner August 31, 2023 15:32
@github-actions github-actions Bot added the conda label Aug 31, 2023
Comment thread dependencies.yaml Outdated
- c-compiler
- cxx-compiler
- dlpack>=0.5,<0.6.0a0
- zlib

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wence- Can you comment on where/how we use zlib? Does it need to be in the conda package dependencies (meta.yml for libcudf, or cudf, …) as well?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue documenting the problems you see in builds?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is now: #14021

@vyasr vyasr Aug 31, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We support zlib compression/decompression in ORC reading/writing, so we should be including it in our recipe.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I was missing: #14021 (comment)

Comment thread conda/recipes/libcudf/meta.yaml Outdated
Comment thread conda/recipes/libcudf/meta.yaml Outdated
@ajschmidt8 ajschmidt8 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 31, 2023

@bdice bdice left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, this looks right to me.

@vyasr vyasr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vuule do you know if there's a specific version of zlib that we require for our use cases? Wondering if we need a lower bound here.

@ajschmidt8 ajschmidt8 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ops-codeowner file changes

@vuule

vuule commented Aug 31, 2023

Copy link
Copy Markdown
Contributor

@vuule do you know if there's a specific version of zlib that we require for our use cases? Wondering if we need a lower bound here.

I'm pretty sure we go back quite a bit and have the same API available. I'm looking at their changelog, and there are bug fixes in every release. Based on this, should we make 1.2.13 the lower bound? It was released Oct 2022.

@wence-

wence- commented Aug 31, 2023

Copy link
Copy Markdown
Contributor Author

@vuule do you know if there's a specific version of zlib that we require for our use cases? Wondering if we need a lower bound here.

I'm pretty sure we go back quite a bit and have the same API available. I'm looking at their changelog, and there are bug fixes in every release. Based on this, should we make 1.2.13 the lower bound? It was released Oct 2022.

Done.

@vyasr vyasr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lower bound looks reasonable to me.

@vyasr

vyasr commented Aug 31, 2023

Copy link
Copy Markdown
Contributor

/merge

@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Aug 31, 2023
@rapids-bot
rapids-bot Bot merged commit a2fd688 into NVIDIA:branch-23.10 Aug 31, 2023
@wence-
wence- deleted the wence/fix/depend-zlib-explicit branch August 31, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] libcudf CI builds failing due to lack of zlib package

6 participants