Don't constrain numba<0.58 - #14616
Merged
Merged
Conversation
brandon-b-miller
added
feature request
bdice
approved these changes
Dec 12, 2023
Contributor
|
Should we test with development builds of numba 0.59 to ensure we don't see breakage from that release? I'm happy either way, just wanted to pose the question. cc: @gmarkall |
galipremsagar
approved these changes
Dec 12, 2023
raydouglass
approved these changes
Dec 12, 2023
Contributor
Could try adding their dev channel |
jakirkham
reviewed
Dec 14, 2023
jakirkham
reviewed
Dec 14, 2023
Contributor
|
For clarity don't think the test actually worked: #14616 (comment) |
Contributor
Author
|
/merge |
raydouglass
added a commit
that referenced
this pull request
Feb 13, 2024
I think unpinning `numba` in the conda recipe was just missed in #14616. I discovered this issue [trying to build the `24.02` release](https://github.com/rapidsai/cudf/actions/runs/7878153691/job/21496377912#step:7:1674). PRs & nightly builds are working because the `rapidsai-nightly` channel has an older version of `pynvjitlink` that supported `numba>=0.57` whereas the `rapidsai` channel only has the latest version which pins to `numba>=0.58`. Authors: - Ray Douglass (https://github.com/raydouglass) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) - Bradley Dice (https://github.com/bdice)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the constraint for numba 0.58 in our dependencies.
Closes #14160