Split cuda versions for notebook testing - #14722
Merged
rapids-bot[bot] merged 3 commits intoJan 9, 2024
Merged
Conversation
ajschmidt8
approved these changes
Jan 8, 2024
Contributor
Author
|
Environment before: After this change: |
Contributor
Author
|
/merge |
bdice
requested changes
Jan 8, 2024
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
bdice
approved these changes
Jan 8, 2024
3 tasks
Contributor
|
I updated this branch to include #14723, which should unblock tests. |
3 tasks
ajschmidt8
pushed a commit
that referenced
this pull request
Jan 11, 2024
Follow-up to #14644. Contributes to rapidsai/build-planning#7. Similar to rapidsai/rmm#1422, this proposes splitting the `cuda-version` dependency in `dependencies.yaml` out to its own thing, separate from the bits of the CUDA Toolkit `cudf` needs. Some other simplifications: * removes the notebook-specific stuff added in #14722 (which I think were added specifically because `cuda-version` and CTK stuff was coupled) * consolidates two sections with selectors only based on CUDA `{major}.{minor}` Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Ray Douglass (https://github.com/raydouglass) - Bradley Dice (https://github.com/bdice) - Vyas Ramasubramani (https://github.com/vyasr)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #14648
Since
rapidsai/dockertests the notebooks on both CUDA 11.8 & 12.0, we need a CUDA 11.8 version of thetest_notebooksfile key.Without this change rdfg wlll always generate an environment with
cuda-version=12.0even when the matrix is for CUDA 11.8 and then it will conflict with other repos (as see here).Checklist