Skip to content

Consolidate cudf object handling in as_column - #14754

Merged
rapids-bot[bot] merged 5 commits into
NVIDIA:branch-24.02from
mroeschke:ref/as_column/cudf_objs
Jan 19, 2024
Merged

Consolidate cudf object handling in as_column#14754
rapids-bot[bot] merged 5 commits into
NVIDIA:branch-24.02from
mroeschke:ref/as_column/cudf_objs

Conversation

@mroeschke

Copy link
Copy Markdown
Contributor

Description

Since these paths are very similar, consolidating these paths and returning early for this case

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 12, 2024
@mroeschke
mroeschke requested a review from a team as a code owner January 12, 2024 18:37

@vyasr vyasr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple suggestions, but nothing blocking. Would wait for @shwina's feedback on the nan_as_null question.

Comment thread python/cudf/cudf/core/column/column.py Outdated
Comment thread python/cudf/cudf/core/column/column.py Outdated
Comment thread python/cudf/cudf/core/column/column.py Outdated
@vyasr

vyasr commented Jan 19, 2024

Copy link
Copy Markdown
Contributor

/merge

@rapids-bot
rapids-bot Bot merged commit 09b6e45 into NVIDIA:branch-24.02 Jan 19, 2024
@mroeschke
mroeschke deleted the ref/as_column/cudf_objs branch January 19, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants