Fix shared-workflows repo name - #14784
Merged
Merged
Conversation
bdice
approved these changes
Jan 18, 2024
bdice
left a comment
bdice
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Can you also remove -DNVBench_ENABLE_CUPTI=OFF from the devcontainer job while we're here? That is no longer needed. Otherwise we can file a separate PR for that, but it feels like a small enough change to wrap into another PR and conserve CI resources.
vyasr
approved these changes
Jan 18, 2024
vyasr
left a comment
vyasr
left a comment
Contributor
There was a problem hiding this comment.
I took care of removing the cupti flag.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-24.02 #14784 +/- ##
===============================================
Coverage ? 86.05%
===============================================
Files ? 175
Lines ? 27441
Branches ? 0
===============================================
Hits ? 23614
Misses ? 3827
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Contributor
|
/merge |
ajschmidt8
approved these changes
Jan 19, 2024
rapids-bot Bot
pushed a commit
to NVIDIA/cuml
that referenced
this pull request
Jan 20, 2024
Fix the repo name for `shared-workflows` See: NVIDIA/cudf#14784 Authors: - Ray Douglass (https://github.com/raydouglass) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) URL: #5723
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the repo name for
shared-workflowsChecklist