Fix total_byte_size in Parquet row group metadata - #14802
Merged
Conversation
vuule
reviewed
Jan 19, 2024
vuule
approved these changes
Jan 19, 2024
vuule
left a comment
vuule
left a comment
Contributor
There was a problem hiding this comment.
nice catch! I wonder how this impacted the chunked reader.
Co-authored-by: Vukasin Milovanovic <vmilovanovic@nvidia.com>
vuule
added
bug
Contributor
|
/ok to test |
vyasr
approved these changes
Jan 19, 2024
vyasr
left a comment
vyasr
left a comment
Contributor
There was a problem hiding this comment.
One very minor suggestion, but feel free to skip. Nice find!
Contributor
|
/ok to test |
Contributor
|
/ok to test |
Contributor
|
/ok to test |
nvdbaranec
approved these changes
Jan 22, 2024
Contributor
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
total_byte_sizefield in the row group metadata should be "[t]otal byte size of all the uncompressed column data in this row group". cuDF currently populates this field with the compressed size. This PR fixes that and adds a test.Checklist