Skip to content

Update udf_cpp to use rapids_cpm_cccl. - #15331

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:branch-24.06from
bdice:rapids_cpm_cccl-in-udf_cpp
Mar 25, 2024
Merged

Update udf_cpp to use rapids_cpm_cccl.#15331
rapids-bot[bot] merged 1 commit into
NVIDIA:branch-24.06from
bdice:rapids_cpm_cccl-in-udf_cpp

Conversation

@bdice

@bdice bdice commented Mar 18, 2024

Copy link
Copy Markdown
Contributor

Description

This PR updates the udf_cpp target to use rapids_cpm_cccl. The previous rapids_cpm_libcudacxx has been deprecated.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice
bdice changed the base branch from branch-24.04 to branch-24.06 March 18, 2024 19:26
@github-actions github-actions Bot added Python Affects Python cuDF API. CMake CMake build issue labels Mar 18, 2024
@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 18, 2024
@bdice bdice self-assigned this Mar 18, 2024
@bdice bdice changed the title Update udf_cpp to use rapids_cpm_cccl." Update udf_cpp to use rapids_cpm_cccl. Mar 18, 2024
@bdice

bdice commented Mar 18, 2024

Copy link
Copy Markdown
Contributor Author

@robertmaynard Do you have thoughts on whether this should target 24.04 or 24.06, due to the deprecation?

@bdice
bdice marked this pull request as ready for review March 18, 2024 22:11
@bdice
bdice requested a review from a team as a code owner March 18, 2024 22:11
@robertmaynard

robertmaynard commented Mar 25, 2024

Copy link
Copy Markdown
Contributor

@robertmaynard Do you have thoughts on whether this should target 24.04 or 24.06, due to the deprecation?

Go with 24.06, we will just suffer with warning when building 24.04

@bdice

bdice commented Mar 25, 2024

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit 933e32a into NVIDIA:branch-24.06 Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar was automatically assigned from rapidsai/cudf-python-codeowners
@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca was automatically assigned from rapidsai/cudf-python-codeowners
1 more reviewer
@shwina shwina shwina approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@bdice bdice

Labels

CMake CMake build issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bdice @robertmaynard @shwina