Add some missing optional fields to the Parquet RowGroup metadata - #15421
Merged
Conversation
hyperbolic2346
left a comment
hyperbolic2346
left a comment
Contributor
There was a problem hiding this comment.
Looking good. Some questions/comments.
hyperbolic2346
added
3 - Ready for Review
Contributor
|
/ok to test |
hyperbolic2346
approved these changes
Apr 8, 2024
Contributor
|
/ok to test |
Contributor
|
/ok to test |
Contributor
|
/ok to test |
Contributor
|
/ok to test |
Contributor
Author
|
@vuule could you take a look at this one? 🙏 Mike's gonna get tired of "ok to test"ing it 🤣 |
vuule
self-requested a review
April 23, 2024 21:22
vuule
approved these changes
Apr 23, 2024
vuule
left a comment
vuule
left a comment
Collaborator
There was a problem hiding this comment.
a sad day for us pickers... a nit-less PR
Collaborator
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
sorting_columns,file_offset,total_compressed_size, andordinaloptional fields to the ParquetRowGroupmetadata object.Checklist