Remove deprecated strings offsets_begin - #15454
Merged
rapids-bot[bot] merged 2 commits intoApr 8, 2024
Merged
Conversation
davidwendt
added
2 - In Progress
davidwendt
added
3 - Ready for Review
davidwendt
marked this pull request as ready for review
April 4, 2024 21:06
bdice
approved these changes
Apr 5, 2024
shrshi
approved these changes
Apr 5, 2024
davidwendt
added
breaking
Contributor
Author
|
Even though this is removing a deprecated function, changing this to breaking since consumers would be affected. |
Contributor
Author
|
/merge |
Collaborator
IMO every PR removing deprecated functions should be marked as breaking since that's when the functionality actually becomes unavailable. Conversely PRs that deprecate functionality typically shouldn't be marked as breaking since calling code will continue to work. Of course, it's a blurry line since code compiled with e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the deprecated
cudf::strings_column_view::offsets_begin()andcudf::strings_column_view::offsets_end()member functions. These are replaced with offsetalator wrapper calls instead.Checklist