Skip to content

Make some private class properties not settable - #15527

Merged
rapids-bot[bot] merged 2 commits into
NVIDIA:branch-24.06from
mroeschke:ref/props/no_setting
Apr 15, 2024
Merged

Make some private class properties not settable#15527
rapids-bot[bot] merged 2 commits into
NVIDIA:branch-24.06from
mroeschke:ref/props/no_setting

Conversation

@mroeschke

Copy link
Copy Markdown
Contributor

Description

It appears these properties do not map to public APIs, and for better state management, these @propertys are better left not settable.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 12, 2024
@mroeschke
mroeschke requested a review from a team as a code owner April 12, 2024 23:54
@mroeschke
mroeschke requested review from bdice and isVoid April 12, 2024 23:54
@mroeschke

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit 64229b9 into NVIDIA:branch-24.06 Apr 15, 2024
@mroeschke
mroeschke deleted the ref/props/no_setting branch April 15, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants