Skip to content

Refactor JNI native dependency loading to allow returning of library path - #15566

Merged
rapids-bot[bot] merged 2 commits into
NVIDIA:branch-24.06from
jlowe:jni-native-deps-refactor
Apr 19, 2024
Merged

Refactor JNI native dependency loading to allow returning of library path#15566
rapids-bot[bot] merged 2 commits into
NVIDIA:branch-24.06from
jlowe:jni-native-deps-refactor

Conversation

@jlowe

@jlowe jlowe commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

Description

Adds a method to NativeDepsLoader that allows loading a dependency and determining the temporary file path the dependency was loaded from. Also refactors the methods to take the dependency preservation flag as a parameter rather than lower-level functions directly reading the global flag, making them more flexible for reuse.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jlowe jlowe added Java Affects Java cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 18, 2024
@jlowe jlowe self-assigned this Apr 18, 2024
@jlowe
jlowe requested a review from a team as a code owner April 18, 2024 16:04
@jlowe

jlowe commented Apr 19, 2024

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit 045f29d into NVIDIA:branch-24.06 Apr 19, 2024
@jlowe
jlowe deleted the jni-native-deps-refactor branch April 19, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants