Use experimental make_strings_children in nvtext APIs - #15595
Merged
Conversation
davidwendt
added
2 - In Progress
33 tasks
davidwendt
added
3 - Ready for Review
davidwendt
marked this pull request as ready for review
April 25, 2024 13:10
vuule
approved these changes
Apr 29, 2024
bdice
approved these changes
Apr 30, 2024
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates nvtext replace, ngram, normalize, and detokenize functions to replace the existing calls to
make_strings_childrenwith the new experimentalmake_strings_childrenwhich supports building large strings.Reference #15579
Checklist