Remove NVBench SHA override. - #15633
Merged
Merged
Conversation
The necessary changes have been made in upstream rapids-cmake.
github-actions
Bot
added
libcudf
Contributor
Author
|
@davidwendt @robertmaynard This should complete the recent changes to the NVBench fixtures. Let me know if there's anything needed for this. |
robertmaynard
requested changes
May 1, 2024
Co-authored-by: Robert Maynard <robertjmaynard@gmail.com>
robertmaynard
approved these changes
May 2, 2024
Contributor
|
@alliepiper You just need to add 2024 to the copyright line in |
bdice
approved these changes
May 2, 2024
bdice
left a comment
bdice
left a comment
Contributor
There was a problem hiding this comment.
I went ahead and pushed the copyright change so CI could rerun -- also I deleted an extra newline.
bdice
added
improvement
Contributor
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The override is no longer necessary as rapids-cmake now uses the same version that was set by the override.
Refs rapidsai/rapids-cmake#584, #15492
Checklist