Skip to content

Fix maxima of categorical column - #15701

Merged
rapids-bot[bot] merged 5 commits into
NVIDIA:branch-24.06from
rjzamora:fix-cat-maxima
May 10, 2024
Merged

Fix maxima of categorical column#15701
rapids-bot[bot] merged 5 commits into
NVIDIA:branch-24.06from
rjzamora:fix-cat-maxima

Conversation

@rjzamora

@rjzamora rjzamora commented May 8, 2024

Copy link
Copy Markdown
Contributor

Closes #15641

Applies patch suggested by @wence-

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@rjzamora rjzamora added bug Something isn't working 2 - In Progress Currently a work in progress non-breaking Non-breaking change labels May 8, 2024
@rjzamora rjzamora self-assigned this May 8, 2024
@github-actions github-actions Bot added the Python Affects Python cuDF API. label May 8, 2024
Comment thread python/cudf/cudf/tests/test_categorical.py
Comment thread python/cudf/cudf/tests/test_categorical.py Outdated
@rjzamora
rjzamora marked this pull request as ready for review May 8, 2024 16:12
@rjzamora
rjzamora requested a review from a team as a code owner May 8, 2024 16:12
@rjzamora
rjzamora requested review from galipremsagar and wence- May 8, 2024 16:12
@rjzamora rjzamora added 3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond and removed 2 - In Progress Currently a work in progress 3 - Ready for Review Ready for review by team labels May 8, 2024
@rjzamora rjzamora added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 4 - Needs Review Waiting for reviewer to review or respond labels May 10, 2024
@rjzamora

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit e93782f into NVIDIA:branch-24.06 May 10, 2024
@rjzamora
rjzamora deleted the fix-cat-maxima branch May 10, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Cannot find maxima of a categorical series

3 participants