Expose stream parameter in public reduction APIs - #15737
Merged
rapids-bot[bot] merged 3 commits intoMay 16, 2024
Merged
Conversation
github-actions
Bot
added
libcudf
davidwendt
added
improvement
Contributor
|
/ok to test |
davidwendt
approved these changes
May 13, 2024
Contributor
Author
|
Hello, |
davidwendt
requested changes
May 14, 2024
Contributor
Author
|
Thank you @davidwendt. Your suggestions worked out! |
Contributor
|
/ok to test |
davidwendt
approved these changes
May 14, 2024
vuule
added
5 - Ready to Merge
Collaborator
|
/ok to test |
PointKernel
approved these changes
May 15, 2024
PointKernel
left a comment
PointKernel
left a comment
Member
There was a problem hiding this comment.
LGTM
@srinivasyadav18 Welcome and thanks for the contribution!
Just FYI, CI is broken right now thus it will take a bit longer to merge the current PR.
Member
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add stream parameter to public reduction APIs:
reduce()segmented_reduce()scan()minmax()Reference #13744
Checklist