Skip to content

Eliminate circular reference in DataFrame/Series.iloc/loc - #15749

Merged
rapids-bot[bot] merged 2 commits into
NVIDIA:branch-24.06from
mroeschke:bug/circular_ref/indexing
May 15, 2024
Merged

Eliminate circular reference in DataFrame/Series.iloc/loc#15749
rapids-bot[bot] merged 2 commits into
NVIDIA:branch-24.06from
mroeschke:bug/circular_ref/indexing

Conversation

@mroeschke

Copy link
Copy Markdown
Contributor

Description

closes #15748

The performance implication can be seen in the issue

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added bug Something isn't working Python Affects Python cuDF API. non-breaking Non-breaking change labels May 14, 2024
@mroeschke
mroeschke requested a review from a team as a code owner May 14, 2024 21:02
@mroeschke
mroeschke requested review from isVoid and wence- May 14, 2024 21:02

@wence- wence- left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@mroeschke

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit b5f6aa5 into NVIDIA:branch-24.06 May 15, 2024
@mroeschke
mroeschke deleted the bug/circular_ref/indexing branch May 15, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] iloc/loc keeps circular reference to original DataFrame/Series

3 participants