Avoid index-to-column conversion in some DataFrame ops - #15763
Merged
rapids-bot[bot] merged 11 commits intoMay 21, 2024
Conversation
mroeschke
added
Python
| other.index.to_pandas() | ||
| ) | ||
| ) | ||
| and not ( |
Contributor
There was a problem hiding this comment.
I think we need to revert my suggestion, because from the diff I thought everything below was inside this if block, but they are outside of it.
Contributor
Author
There was a problem hiding this comment.
I just had to move the walrus condition to the top so the if branch doesn't short circuit without defining these variables
Contributor
Author
There was a problem hiding this comment.
Moving the condition looked to have done the trick and all green here
galipremsagar
approved these changes
May 21, 2024
Contributor
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
xref #15494
Index.str, check thedtypeinstead of the underlying column type (which would materialize RangeIndex)set_index, don't immediately convert passed objects to column until necessary_make_operands_and_index_for_binop, don't create pandas object more than onceChecklist