Move Accessor implementation to their own directory - #19134
Merged
Conversation
mroeschke
added
Python
vyasr
approved these changes
Jun 11, 2025
vyasr
left a comment
vyasr
left a comment
Contributor
There was a problem hiding this comment.
I skimmed but LGTM assuming that docs builds pass (that's where I think it's most likely that we missed a necessary change).
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The implementation for cuDF accessors (e.g.
Series.str/list/cat/struct) lived incudf/core/column, before redesigning the cuDF Python column around pylibcudf, xref #18726, it would be great if this auxiliary implementation was moved into its own namespace,cudf/core/accessorsThis PR is 99% moving code and 1% updating some type annotations.
Checklist