Simplify categorical column - #20942
Merged
rapids-bot[bot] merged 9 commits intoDec 24, 2025
Merged
Conversation
mroeschke
approved these changes
Dec 23, 2025
mroeschke
left a comment
mroeschke
left a comment
Contributor
There was a problem hiding this comment.
The pandas tests failures may be real, but the changes LGTM
Contributor
Author
They are real indeed. Took some doing to track down, but it's good they failed since it's a bug we really should be catching in our own test suite. Fixed. |
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes CategoricalColumn.codes a trivial access to
self.children[0], so there is no longer a separateself._codesattribute storing a masked version of the child column. With that change, we can also remove the need forto_pylibcudfto support theuse_baseparameter, which was only false to support setting the mask on the categorical codes due to the separation between the codes' mask and the categorical's mask.to_pylibcudfalso no longer needs specialized handling for categorical columns since a simple override in CategoricalColumn is sufficient. Additionally, we can remove multiple overrides of parent methods from CategoricalColumn that only served to maintain the codes.Checklist