Support decimal operators with different scales in AST - #22122
Merged
Conversation
davidwendt
added
2 - In Progress
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test |
davidwendt
added
3 - Ready for Review
davidwendt
marked this pull request as ready for review
April 14, 2026 14:51
bdice
approved these changes
Apr 16, 2026
shrshi
approved these changes
Apr 17, 2026
Contributor
Author
|
/merge |
shrshi
pushed a commit
to shrshi/cudf
that referenced
this pull request
May 12, 2026
Adds support for decimal types with different scales as operands in AST expressions. This only required relaxing the type-matching check to ignore scale for decimals. The existing AST logic was already setup to allow different decimal scale values in operands. Most of the changes here are adding gtests. Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Bradley Dice (https://github.com/bdice) - Shruti Shivakumar (https://github.com/shrshi) URL: NVIDIA#22122
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for decimal types with different scales as operands in AST expressions.
This only required relaxing the type-matching check to ignore scale for decimals.
The existing AST logic was already setup to allow different decimal scale values in operands.
Most of the changes here are adding gtests.
Checklist