Add cudf::strings::count API for literal strings - #22288
Merged
Merged
Conversation
davidwendt
added
feature request
bdice
approved these changes
Apr 24, 2026
mhaseeb123
approved these changes
Apr 24, 2026
Contributor
Author
|
/merge |
vyasr
pushed a commit
to vyasr/cudf
that referenced
this pull request
May 4, 2026
Adds a new libcudf API for counting string matches within rows of a strings column. This is meant to be a fast-path option for the current `cudf::strings::count()` which only accepts a regex pattern. If that API determines the pattern only contains a literal string (no regex pattern or flags) then this can be called internally automatically. Exposing this as a public API provides some consistency with other APIs like `find`, `contains`, and `split` which have both regex and non-regex versions. This API will match the behavior of the regex count API which includes not counting overlapping matches. Reference fast-path logic being worked on here: NVIDIA#22178 Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Bradley Dice (https://github.com/bdice) - Muhammad Haseeb (https://github.com/mhaseeb123) URL: NVIDIA#22288
shrshi
pushed a commit
to shrshi/cudf
that referenced
this pull request
May 12, 2026
Adds a new libcudf API for counting string matches within rows of a strings column. This is meant to be a fast-path option for the current `cudf::strings::count()` which only accepts a regex pattern. If that API determines the pattern only contains a literal string (no regex pattern or flags) then this can be called internally automatically. Exposing this as a public API provides some consistency with other APIs like `find`, `contains`, and `split` which have both regex and non-regex versions. This API will match the behavior of the regex count API which includes not counting overlapping matches. Reference fast-path logic being worked on here: NVIDIA#22178 Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Bradley Dice (https://github.com/bdice) - Muhammad Haseeb (https://github.com/mhaseeb123) URL: NVIDIA#22288
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new libcudf API for counting string matches within rows of a strings column. This is meant to be a fast-path option for the current
cudf::strings::count()which only accepts a regex pattern. If that API determines the pattern only contains a literal string (no regex pattern or flags) then this can be called internally automatically. Exposing this as a public API provides some consistency with other APIs likefind,contains, andsplitwhich have both regex and non-regex versions.This API will match the behavior of the regex count API which includes not counting overlapping matches.
Reference fast-path logic being worked on here: #22178
Checklist