Remove obsolete distinct filtered join wrapper - #23520
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test 810dddb |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (7)
💤 Files with no reviewable changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe PR removes ChangesFiltered join consolidation
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related issues
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
|
/merge |
Description
This PR removes the obsolete
cudf::detail::distinct_filtered_joinwrapper and moves its semi/anti join implementation intocudf::detail::filtered_join.Since
cudf::mark_joinhandles left-table reuse andcudf::filtered_joinhandles right-table reuse, filtered join has only one concrete implementation. This removes the unnecessary virtual hierarchy and keeps hash-table construction, insertion, and probing in one class without changing behavior.Checklist