TEST: Merge import subprocess checks - #24010
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe pull request removes an obsolete S3 import test and extends the no-device cuDF import test to verify that ChangescuDF import test validation
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This change consolidates cuDF import-invariant coverage while preserving the no-device check and verifying that importing cuDF does not load pyarrow._s3fs. No current merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
bdice
left a comment
There was a problem hiding this comment.
Does this test take a lot of time? I agree these can be combined but we are really testing two different things (s3fs and no devices) that now appear under a single test name.
This is a pretty tiny improvement yeah. I added it since at this point I'm taking every win I can, but it's miniscule on the scale of everything else. These tests take 3-4s each, so combining them shaves that off. Since this PR is already up, I'll just add some helpful comments and rename the test for clarity, but if we find it odd later I'm happy to split it back out. |
|
/merge |
Description
Merge the two isolated import subprocess checks. The existing no-device subprocess now also asserts that importing cuDF does not import
pyarrow._s3fs.Both contracts are still verified after the same cold, isolated cuDF import, so this removes only a redundant Python startup and not any assertion.
Checklist