Use string literals in fixed_point release_asserts - #7303
Merged
Conversation
codereport
added
3 - Ready for Review
jrhemstad
reviewed
Feb 4, 2021
devavret
approved these changes
Feb 4, 2021
devavret
left a comment
devavret
left a comment
Contributor
There was a problem hiding this comment.
What Jake said. And also, thank you.
trxcllnt
approved these changes
Feb 4, 2021
codereport
added
5 - Ready to Merge
Contributor
Author
|
@gpucibot merge |
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7303 +/- ##
==============================================
Coverage ? 82.21%
==============================================
Files ? 100
Lines ? 16955
Branches ? 0
==============================================
Hits ? 13939
Misses ? 3016
Partials ? 0 Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release_assertis only happy with string literals, notconst car*and notstd::string. Solution is to removeprint_repand just use a string literal.